The MR is about 4 weeks old now and the maintainers haven’t looked at it yet
Looks like someone gave a review about 15hrs before this post
this post was submitted on 27 Nov 2023
205 points (98.6% liked)
Linux
46819 readers
1087 users here now
From Wikipedia, the free encyclopedia
Linux is a family of open source Unix-like operating systems based on the Linux kernel, an operating system kernel first released on September 17, 1991 by Linus Torvalds. Linux is typically packaged in a Linux distribution (or distro for short).
Distributions include the Linux kernel and supporting system software and libraries, many of which are provided by the GNU Project. Many Linux distributions use the word "Linux" in their name, but the Free Software Foundation uses the name GNU/Linux to emphasize the importance of GNU software, causing some controversy.
Rules
- Posts must be relevant to operating systems running the Linux kernel. GNU/Linux or otherwise.
- No misinformation
- No NSFW content
- No hate speech, bigotry, etc
Related Communities
Community icon by Alpár-Etele Méder, licensed under CC BY 3.0
founded 5 years ago
MODERATORS
Yep, I'm working through the review. He's a contributor though not a maintainer.
This sounds like a big improvement to me. Can users vote for mr?
You can react to the MR with an emoji if you have a gnome gitlab account. I'm not sure if there are mechanisms to vote for MRs other than that.
Sounds amazing to me. I don't use gnome on a laptop much thusfar but I'd definitely prefer what you describe here
I know that this is probably some close-sourced shenanigans, but can I push the limits of brightness below what GNOME sets? In Windows, I could go as low as I could, but this isn't possible in GNOME anymore.
Typically their is some sort of low-level knob in /sys (try find /sys | grep backlight) which can be used to set it to any value. Be careful playing around though because 0 is often completely off and it can be hard to set it back. (Although a reboot should fix it if nothing tries to be clever and preserve it at shutdown.)
With my code, the lowest brightness setting should be closer to the minimum supported by the screen. There are some limitations with this because some screens become flickery at very low brightness levels. You might be able to circumvent the lower limit by using something other than the gnome settings daemon to set the brightness.
I can see you've gotten some code review so I will just eagerly watch as this gets worked out and eventually merged.
I never had an issue with the backlight curve or lack thereof however a friend recently demoed a similar impl they put together for hyprland and it is a very nice change.
Looking forward to seeing it in the next Gnome release 🤞
This is really cool. I would like to see it merged
Sounds great, and is very welcome! Please merge. Thank you. Do you guys have any idea why ddc/ci controls for brightness control of external screens are not yet implemented in any major De? It's the same on windows, still not part of the Os. Third party tools available since ages.
there is a ddcci dkms driver that exposes displays as Linux backlight devices. That integrates them into all DEs!
But are there any DEs that make use of this and include setting screen brightness on external screens as easy as for laptops? Is it because each screen manufacturer implements altering brightness/contrast/etc. via ddcci differently?
yes, all of them. That's how laptop screen brightness is controlled
Didn't know I wanted this, unfortunately I use Cinnamon, but this is a great feature!
I only use gnome on my laptop, where I luckily have buttons to control brightness, but this seems like a really good thing to get implemented.