823
The eye-opener commit (discuss.tchncs.de)
submitted 7 months ago by [email protected] to c/[email protected]
31 comments fedilink hide all child comments
all 32 comments
sorted by: hot top controversial new old
[-] [email protected] 138 points 7 months ago

I remember when I was working with .NET and I saw some web service code and I saw there was no try catches. They didn't have a global catch in the asax either or anything. I just wrapped each call into a try catch and log.

I got the same treatment where my manager wanted to know what happened with the increase in errors. I told him what I did. My manager got another developer to go through my commits regardless. I was a bit upset at the lack of trust.

[-] [email protected] 49 points 7 months ago

I mean, that 'could' be a straight up wrong thing to do if some of the calls were expecting errors to be able to escape. Yea, it'd be super weird and I don't know if .NET would marshall them anywhere, but in some systems, that sort of, "obvious" fix could break shit. Sure, it'd be something doing something weird and kinda' dumb, but ... don't we see "weird and dumb" all the time??

[-] [email protected] 40 points 7 months ago

oh yeah I just logged and rethrew, so it shouldn't have had any behavior change, but I could have broken something I make mistakes all the time.

The errors we were seeing in logs were like logic or application errors that we just didn't see before. My changes really shouldn't have caused.

[-] [email protected] 18 points 7 months ago

I think that was the right approach, then again didn't you have through a pull request or at least a code review? Knowing that would give raise to so many "errors" you should have had some sort of communication beforehand.

I don't blame you, more the workflow and ironically the manager

[-] [email protected] 12 points 7 months ago

Oh that was like years ago! Probably SVN, we on-boarded Git a little while after.

No pull requests, you just manually merged back then. It's definitely a workflow improvement we adopted later and we as a company and as an industry have gotten better.

lol, the thing was just that my manager asked me what I did and I told him. Him getting another dev to "fact-check" me after is what bothered me a bit. I am usually the type of look into issues rather than brush them off and I am the first to confess to a screw up. Which is why I was irked.

[-] [email protected] 21 points 7 months ago

A manager that can't read a simple try catch commit? Why am I surprised.

[-] [email protected] 31 points 7 months ago* (last edited 7 months ago)

they shouldn't have to do that. the commit log tells the manager who to go ask.

and since the developer did that to be a big swinging dick instead of bringing it up to the team in a meeting as a problem to address together the manager didn't trust them.

makes sense to people that have to manage other humans.

[-] [email protected] 73 points 7 months ago

Changing the error level in the build config without telling everyone and then making a hyperbolic passive aggressive comic when the senior admonishes you for doing so ?

I'm gonna guess 1 YoE, second job out of college. Enough experience to know what they're doing, but not enough to know when to do it.

[-] [email protected] 61 points 7 months ago

It's the delusion stage, when you think companies are places where you do professional work. Then you learn no one cares about properly doing your job. In fact, they'd rather you do not.

[-] [email protected] 15 points 7 months ago

Ah, that hits close to home. I have spent a lot of time and energy to get my direct bosses onboard with following best practices and doing things right from the start. To their credit, they got onboard with it and are pushing that message themselves now. Of course, the board doesn't care about that and just jams random projects with strict deadlines without any thoughts given to the IT aspects of it up our asses, but our head of IT has apparently grown a spine and started pushing back, with some moderate success.

The MO of my company has for years been: do a POC and then as soon as it works, push that POC in production. I'm still cleaning up the mess of idiotic shit like that from 15 years ago.

[-] [email protected] 3 points 7 months ago

Ultimately, the quality of your work is a function of you and your resources. Corruption and miscommunication plague all management systems. Corrupt management siphons resources away from otherwise good work. Government bureaucracy is another layer of management like any other. Customers are not just consumers but working people like you.

Hang in there.

[-] [email protected] 12 points 7 months ago

Tbh the fact that they were even ABLE to push something like that without anyone noticing is a red flag for the work environment and workflow.

[-] [email protected] 57 points 7 months ago

I would normally put an if-statement before that to verify if IGNORANCE still equals BLISS

[-] [email protected] 54 points 7 months ago

The second panel would be "No, I enabled error reporting. Those errors belong to just you."

[-] [email protected] 36 points 7 months ago

But it works fine on MY computer.

[-] [email protected] 49 points 7 months ago

"But we can't ship your computer!" and so Docker was born.

[-] [email protected] 19 points 7 months ago

No, we cannot just put every random library on the server. Please stick to the stable ones the team picked, not random ones you just heard about and wanted to try in production.

Docker enters the chat: Now you can!

[-] xmunk 7 points 7 months ago

For some reason our executable only works if you include a jpg of a coconut... do you want to debug why or just ship it?

[-] [email protected] 2 points 7 months ago

Shit that sounds familiar. Like the jpg was large enough to push the binary into some random memory region.

[-] [email protected] 2 points 7 months ago

Ship it!

[-] [email protected] 3 points 7 months ago

Begins planning a coconut / computer wedding.

[-] [email protected] 28 points 7 months ago

Yay a PHP joke that isn’t making fun of PHP.

[-] [email protected] 26 points 7 months ago

"My project" doesn't exist in any team. It's everyone's project. A manager needs to have a long conversation with Pink Pants.

If you build your project at anything but highest error level, clang -Wall etc., you're letting errors in, relying at best on coincidence to work the way you think it does.

Commit it and don't revert it!

[-] [email protected] 23 points 7 months ago

need a blame.css but for code

[-] [email protected] 3 points 7 months ago

I'll see your blame.css and raise you git blame somebody else

[-] [email protected] 20 points 7 months ago

Source: https://www.commitstrip.com/2015/04/27/the-eye-opener-commit/

Also on twitter:

[-] BruceDoh 7 points 7 months ago

Certificate is expired

[-] [email protected] 5 points 7 months ago

Yep, that's why I added the twitter source too.

[-] [email protected] 8 points 7 months ago* (last edited 7 months ago)

Twitter is also expired.

[-] [email protected] 8 points 7 months ago* (last edited 7 months ago)

That's why PHP team gave us null coalescing (??), oh the misery we went through writing if / else

[-] [email protected] 1 points 7 months ago

who doesnt love ??

this post was submitted on 23 Nov 2023
823 points (97.8% liked)

Programmer Humor

31331 readers
14 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

founded 4 years ago
MODERATORS
[email protected]
[email protected]