Firefox Customs

4 readers

10 users here now

Chat with us!

Post your unsupported Firefox customizations here!

From the makers of r/FirefoxCSS

Links

Related

Firefox

Rules

Posts must have flair!
Posts cannot be memes/shitposts. They should be about Firefox customization with CSS.
Please be civil. Bear in mind that many users come here for help and would be turned off by insults and rudeness.
When posting large amount of code use a service dedicated to hosting text snippets, such as pastebin, hastebin, github gist or equivalent. Relatively short snippets can be wrapped in code-block for inline viewing.
Do NOT use url-shorteners or link to compressed downloads (such as zip or rar) when sharing code.

founded 1 year ago

MODERATORS

[email protected]

This simple findbar JS script for FF stopped working in 128, how could I fix it? (lemmy.world)

submitted 3 months ago by [email protected] to c/[email protected]

3 comments fedilink hide all child comments

Hello,

I've been using this script for ages, up to the point I forgot that ctrl-f to open and close the findbar wasn't a native behavior. Today I noticed it doesn't work anymore and I think it's FF128 that broke it...but I can't seem to see how to fix it.

Anyone's got ideas?

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 4 points 3 months ago (1 children)

I suspect that the cause is from bug 1897477 - whereas previously your script overrode the original command ctrl+f event callback, with this change both callbacks happen. So when findbar is already shown, your script will hide it, but then the original Firefox function shows it again.

You can probably change the last part to be like this instead (I don't really get what the middle part is supposed to do, but meh):

(function() {
  document.getElementById("cmd_find").addEventListener("command",(ev) => {
    ucjsToggleFindBar();
    ev.stopPropagation();
  }, { capture: true })
})();

[–] [email protected] 1 points 3 months ago (1 children)

Oh I see, a bug was affecting it, curious ahah! Thanks for pointing it out and thanks for the quick fix solution as well :D

[–] [email protected] 1 points 3 months ago

Right, though "bug" here really means an intentional change, not so much something that is broken.