this post was submitted on 23 Nov 2023
121 points (96.9% liked)

Programming

17534 readers
65 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities [email protected]



founded 2 years ago
MODERATORS
 

Many of us write opensource code in a void: nobody ever looks at it, uses it nor reviews it. We are the only users and authors.

In order to improve, where can we get our code reviewed? I don't mean professionally, just from like-minded individuals.

you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 15 points 1 year ago (3 children)

Would love something like this, but it's very hard to get such a community working. Most of the time there will be way more people wanting a review of their code than people wanting to put in the work and review something.

Maybe some kind of point system could work. Like one needs to review at least two times before you can get your work reviewed.

[–] [email protected] 9 points 1 year ago (3 children)

One issue I can see with the points system is that people could just approve it with a "Looks good to me!" without even looking at the code. Or just looking at a small portion of the code.

[–] [email protected] 4 points 1 year ago

Also bike shedding. Simple stuff may get many people willing to review / argue about how you should have used A over B, or even C

Big / complicated projects - forget it. Especially if if they would need major refactoring.

[–] [email protected] 1 points 1 year ago

Yeah that's definitely a possibility. It's really a tricky topic to build a review community. One could try other approaches like dedicated volunteer reviewers. But if you look at exorcism, that will become hard to manage for languages with huge demand.

A system where everyone also needs to review is definitely better. Especially since everyone also learns reading other peoples code.

[–] threelonmusketeers 1 points 1 year ago (1 children)

Could there be a way to award the points proportionally, based on how useful the feedback is?

[–] [email protected] 3 points 1 year ago

But who decides that? If the person who requested it can do this, you only need a friend to abuse the system and give each other a few extra points.

Maybe a open point history could help with this and users moderate themselves with this.

[–] [email protected] 3 points 1 year ago (2 children)

with that there would need some way for people to have things to initially review to get the community started. Could do something like after the first 3 posts the point system goes into effect

[–] [email protected] 2 points 1 year ago (1 children)

True, it's not a fleshed out idea haha. But starting with a few points would work.

Could actually be a cool in it self, wish I had time for something like that.

[–] [email protected] 1 points 1 year ago

Something like c sharp acedemy would be kinda cool. Basically do some beginner projects with good code reviews you get a "belt". That belt allows you to review the beginner projects as you work on intermediate projects. Then you complete those and get another belt that let's you do advanced projects and review the intermediate projects others submitted.

[–] [email protected] 1 points 1 year ago (2 children)

Kinda sounds like a format similar to Stack Exchange might work

[–] [email protected] 5 points 1 year ago

Just remove everything as a duplicate?

[–] [email protected] 2 points 1 year ago

There actually is a Stack Exchange community for code reviews: https://codereview.stackexchange.com/