this post was submitted on 20 Nov 2024
713 points (97.5% liked)

Programmer Humor

19623 readers
2244 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
713
submitted 19 hours ago* (last edited 18 hours ago) by [email protected] to c/[email protected]
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 61 points 11 hours ago (3 children)

I'm not great at English, but "discard all changes" shouldn't ever mean "Delete".

[–] [email protected] 2 points 5 hours ago

the alternative to deleting is emptying the file contents, which is essentially the same...

[–] [email protected] 28 points 10 hours ago (2 children)

In the context of version control it does. Discarding a change that creates a file means deleting the file.

[–] [email protected] 11 points 8 hours ago

If you have set up your staging area for a commit you may want to discard (unstage) changes from the staging area, as opposed to discarding changes in the working directory.

Of course, the difference between the two is obvious if you're using git CLI, but I can easily see someone using a GUI (and that maybe isn't too familiar with git) misunderstanding "discard" as "unstage".

Either way, what happened here indicates that all the files were somehow added to the VC, without having been committed first, or something like that, because git will not let you discard a file that is untracked, because that wouldn't make any sense. The fact that the GUI let this person delete a bunch of files without first committing them to the index is what makes this a terrible design choice, and also what makes the use of the word "discard" misleading.

[–] [email protected] 2 points 8 hours ago (1 children)

Ok fair enough, but I'm under the impression these files existed before the source control was implemented.

I guess it's all up to how the program handles existing files.

[–] [email protected] 2 points 8 hours ago

I guess the newly created git repository was empty, and all the files that was present in the folder represented "changes"

[–] [email protected] 6 points 7 hours ago (1 children)

I'm pretty sure vscode shows a confirmation dialog when discarding changes will permanently delete a file. I've done that recently with temporary files that were no longer needed.

[–] [email protected] 8 points 6 hours ago

I remember following the drama back in the day. That warning you saw was the result of this now-classic bug report.