this post was submitted on 20 Nov 2024
848 points (97.4% liked)

Programmer Humor

19623 readers
11 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
848
submitted 2 days ago* (last edited 2 days ago) by [email protected] to c/[email protected]
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] -2 points 2 days ago (1 children)

What exactly do you think discard means?

[–] [email protected] 66 points 2 days ago (3 children)

“Changes” are not the same thing as “files”.

I’d expect that files that are not in version control would not be touched.

[–] [email protected] 12 points 2 days ago* (last edited 2 days ago)

Yeah. That's discussed in more detail in the code change that resulted from the issue report.

It's a ballsy move by the VSCode team to not only include git clean but to keep it after numerous issue reports.

As others discussed in that thread, git clean has no business being offered in a graphical menu where a git novice may find it.

That said, I do think the expanded warning mesage they added addresses the issue by calling out that whatever git may think, the user is about to lose some files.

[–] [email protected] 11 points 2 days ago* (last edited 2 days ago) (2 children)

Apparently, it means changes to the directory structure and what files are in them, not changes within the files themselves. It really ought to be more clear about this.

[–] [email protected] 4 points 2 days ago* (last edited 2 days ago)

Yeah. They did substantially modify the message to make it much clearer, thankfully.

[–] [email protected] 3 points 2 days ago

It means both.

[–] [email protected] 4 points 2 days ago* (last edited 2 days ago) (2 children)

"Changes" encompass more than you think. Creating / Deleting files are also changes, not just edits to a file.

  • If the change is an edit to a tracked file, "Discard Changes" will reverse the edit.
  • If the change is deleting a tracked file, "Discard Changes" will restore it back.
  • If the change is a new untracked file, "Discard Changes" will remove it as intended.

It can also be all of them at the same time, which is why VSCode uses "Changes" instead of "Files".

[–] [email protected] 24 points 2 days ago (1 children)

And the terminology is misleading, resulting in problems. shrug.

[–] [email protected] 0 points 2 days ago

I find it difficult to lay the blame with VSCode when the terminology belongs to git, which (even 7 years ago) was an industry standard technology.

People using tools they don't understand and plowing ahead through scary warnings will always encounter problems.

[–] [email protected] 7 points 2 days ago

If the change is a new untracked file

Wasn't the issue that it deleted a bunch of preexisting untracked files? So old untracked files.