| Match up | Time |
|---|---|
 LAK -  TOR |
08:00PM EDT |
I am open source! Report issues, contribute, and fund me on my GitHub page!
this post was submitted on 31 Oct 2023
5 points (100.0% liked)
Toronto Maple Leafs
313 readers
10 users here now
Be polite. A reminder: Fan's is obviously a short form for 'Fanatics' so disagree politely. No flaming and/or Racism.***
founded 3 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
Uh, I think there's a bug in the bot. It's not supposed to make this daily thread if you don't have any game types in COMMENT_POST_TYPES. I'll have to look into this over the weekend. I haven't really been able to find the time to work on the bot this week.
Edit: I created an issue for this here: https://github.com/dandroid126/lemmy-nhl-gdt-bot/issues/36
I don't think I'm running the latest image, haven't had a chance to update it and pull the latest, I was going to make sure I was on the latest before I bring it up
So I actually gave this some more thought. I think having a daily thread even when all the games are full posts rather than comments would be nice in the case of [email protected], so during the playoffs you can see an overview of all of the games. However, it’s still useless in your case. I think the way I’m going to do it is if there is 2 or more games in a day, the daily thread gets made. I am testing the change today and hopefully will push it out before the Leafs game. I think your most recent daily thread will get stuck as featured, so you might need to unfeature it manually.
That seems like a great idea. It will still have niche uses for a single team that way. I.e. split squad preseason game days
That change is now live!
I haven't made an update to that area in the lastest image.
I heavily rewrote the logic last weekend to optimize what was being downloaded from the NHL API, and I broke a few things and just haven't gotten around to fixing it.
Before I was downloading all the data for every game every 30 seconds, then discarding the games that weren't relevant right now. But I updated it so it doesn't download anything not from your selected teams and for games that are more than an hour away from starting. This was a much needed optimization, but it introduced several bugs, including this one.
I need to write more unit tests to catch these things! 😭