Rust

5744 readers

8 users here now

Welcome to the Rust community! This is a place to discuss about the Rust programming language.

Wormhole

[email protected]

Credits

The icon is a modified version of the official rust logo (changing the colors to a gradient and black background)

founded 1 year ago

MODERATORS

[email protected]

-54

Pretty critical PR for rust-msi is getting held up because the maintainer understands the intent but not why this works (github.com)

submitted 4 months ago* (last edited 4 months ago) by [email protected] to c/[email protected]

13 comments fedilink hide all child comments

Not to throw shade, just wishing that somebody here can understand. Whenever an input is reasonably long, an analyzing function will crash, and this PR aims to fix that with a mechanism that contradicts the maintainer's understanding while a similar C implementation does not need this fix. ~~Clearly, the maintainer has not heard a certain programming mantra...~~

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 4 points 4 months ago (1 children)

Looks to me like a reasonable conversation is happening trying to find the underlying issue. Where is the PR being held up?

[–] [email protected] -2 points 4 months ago* (last edited 4 months ago) (1 children)

Since I posted it, the conversation has moved forward. Before that it was just two people being justifiably confused.

[–] [email protected] 4 points 4 months ago (1 children)

You must understand that maintainers need to worry about supply chain attacks ever since the xz debacle. So I suggest you wait.

[–] [email protected] 1 points 4 months ago

Thanks. All I wanted was to have someone answer with what's actually going on, and thanks to Giooschi below that has happened, and there indeed isn't anything to do at this point. I've tried to edit the post but couldn't find a proper wording.