this post was submitted on 19 Oct 2023
1706 points (98.8% liked)

Programmer Humor

31812 readers
545 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

founded 5 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] xmunk 181 points 10 months ago (53 children)

Speaking as a Senior Dev specialized in database access and design... you don't have to use all caps - SQL is actually case agnostic.

But... but my fucking eyes man. I'm old, if your branch doesn't have control keywords in all caps I'm going to take it out back and ol' yeller it.

There are few hills I'll die on but all caps SQL and singular table names are two of them.

[–] [email protected] 69 points 10 months ago (5 children)

I'm a sql developer, and I am completely the opposite to you. I will find it incredibly difficult to read when everything is in caps

[–] [email protected] 130 points 10 months ago (2 children)

You should do a project together

[–] [email protected] 41 points 10 months ago (1 children)
[–] [email protected] 30 points 10 months ago

The commit wars will be long and bloody.

[–] [email protected] 24 points 10 months ago (3 children)

Same, I prefer lower case. Every other language has keywords in lower case, why do you need to shout when writing sql?

[–] [email protected] 21 points 10 months ago* (last edited 10 months ago) (4 children)

I understand it as an attempt to get very basic, manual syntax highlighting. If all you have is white text on black background, then I do see the value of making keywords easy to spot by putting them in all caps. And this probably made sense back when SQL was first developed, but it's 2023, any dev / data scientist not using a tool that gives you syntax highlighting seriously needs to get with the times

[–] xmunk 13 points 10 months ago* (last edited 10 months ago)

Partially, yes. I personally use an IDE with excellent syntax highlighting and those have been around for at least two decades. You are, however, often transplanting your SQL between a variety of environments and in some of those syntax highlighting is unavailable (for me at least) - the all caps does help in those rare situations.

More importantly though it helps clearly differentiate between those control keywords (which are universal) and data labels (which are specific to your business domain). If I'm consulting on a complex system that I only partially understand it's extremely helpful to be able to quickly identify data labels that I'm unfamiliar with to research.

[–] [email protected] 8 points 10 months ago* (last edited 10 months ago) (1 children)

it's 2023, any dev / data scientist not using a tool that gives you syntax highlighting seriously needs to get with the times

You say that as if AS400 systems with only console access don't exist anymore.

[–] [email protected] 2 points 10 months ago (1 children)

Well then use all-caps keywords whenever working on those systems, I don't care. But an edge case like that shouldn't dictate the default for everyone else who doesn't have to work on that, that's all I'm saying.

[–] [email protected] 4 points 10 months ago

There are several cases where you'll be limited to console only, or log files, or many many other situations. Good coding practices just makes life easier all around.

[–] [email protected] 8 points 10 months ago* (last edited 10 months ago) (3 children)

Please tell me what IDE you're using that's capable of highlighting SQL syntax that's embedded inside another language source file

Also please fucking stop with the "it's current year stop x." The year is not an argument.

[–] [email protected] 4 points 10 months ago (1 children)

JetBrains IDEs - IntelliJ, WebStorm, PyCharm, GoLand, etc., all support highlighting SQL embedded in another source file or even inside markup files like YAML. Does your IDE not support this?

[–] [email protected] 1 points 10 months ago

RustRover isn't ready for actual usage, I've tried it

[–] xmunk 2 points 10 months ago* (last edited 10 months ago)

Sublime is actually great at that especially when I keep my SQL in heredocs.

[–] [email protected] 2 points 10 months ago (1 children)

As the other commenter said, the Jetbrains IDEs do this perfectly fine. Although I'd also argue that if you're working with SQL from within another language already, a DSL wrapper is probably gonna be the better way to go about this.

[–] [email protected] 2 points 10 months ago* (last edited 10 months ago) (1 children)

Unfortunately RustRover is still garbage for actual usage. And I refuse to use an ORM when I can just write the SQL in a more common syntax that everyone understands across every language instead of whatever inefficient library-of-the-week there is. Raw SQL is fine and can be significantly more performant. Don't be scared.

[–] [email protected] 2 points 10 months ago (1 children)

I'm not talking full blown ORM here, not a fan of those either. I'm talking about some light weight wrapper that basically just assembles SQL statements for you, while giving you just a little more type safety and automatic protection against SQL injection, and not sacrificing any performance. I'm coming from the JVM world, where Jooq and Exposed are examples of that kind of thing.

[–] [email protected] 1 points 10 months ago* (last edited 10 months ago) (1 children)

I'm currently using SQLx which you write raw queries in and it validates them against a currently-running db, using the description of the tables to build the typing for the return type instead of relying on the user. It makes it pretty hard to write anything that supports injection

[–] [email protected] 2 points 10 months ago (1 children)

Oh, that sounds really cool! At what time does this validation happen? While you code, or later at build time?

[–] [email protected] 3 points 10 months ago

Happens at compile time! It's relatively quick. You can also run a command to write the query results to file for offline type checking which is mostly useful for CI

[–] [email protected] 3 points 10 months ago (1 children)

Also some people are color blind.

Also you might need to ssh in somewhere and vi some code or tail a log file where you don’t have color support.

[–] [email protected] 1 points 10 months ago

My ide isn't limited to color when it comes to highlighting, so being color blind generally shouldn't be a problem. Set keywords to underlined, bold, italic, whatever works for you.

Your other examples I can see, but at least at my work those are rare edge cases, and I'd rather optimize for the brunt of the work than for those. Of course at other places those might be much more of a concern.

[–] [email protected] 13 points 10 months ago (1 children)

Just some key words in uppercase (FROM, JOIN,WHERE,etc) so they pop out

[–] xmunk 3 points 10 months ago

Yea - you want the structure in a recognizable form so that you can quickly confirm code patterns for comprehension.

[–] [email protected] 1 points 9 months ago

What about Intercal?

[–] xmunk 18 points 10 months ago* (last edited 10 months ago) (3 children)

Sorry, to clarify, not everything is in all caps. I'll append my prefered syntax below

WITH foo AS (
    SELECT id, baz.binid
    FROM
            bar
        JOIN baz
            ON bar.id = baz.barid
)
SELECT bin.name, bin.id AS binid
FROM
        foo
    JOIN bin
        foo.binid = bin.id

The above is some dirt simple SQL, when you get into report construction things get very complicated and it pays off to make sure the simple stuff is expressive.

[–] [email protected] 14 points 10 months ago (2 children)

You indent your JOIN? Why on earth? It lives in the same context as the SELECT.

[–] xmunk 9 points 10 months ago

I've seen both approaches and I think they're both quite reasonable. An indented join is my preference since it makes sub queries more logically indented... but our coding standards allow either approach. We've even got a few people that like

FROM foo
JOIN bar ON foo.id = bar.fooid
JOIN baz ON bar.id = baz.barid
[–] [email protected] 6 points 10 months ago (1 children)

Actually not. It's part of the FROM

[–] [email protected] 2 points 10 months ago

That double indented from is hurting me

[–] [email protected] 1 points 10 months ago (1 children)

Um you forgot the semicolon before with assuming there isn't one in the previous statement. Syntax error. Code review failed

[–] xmunk 5 points 10 months ago

There's no way we're running in multi statement mode... I like my prepared queries, thank you very much.

[–] [email protected] 2 points 10 months ago

I'm at a Data Engineer and I alternative caps lock and non caps lock at random

[–] [email protected] 1 points 10 months ago* (last edited 10 months ago)

I believe this has been proven. It's because capital letters all have the same shape whereas lower case letters do not. So your brain can take shortcuts to reading lower case but cannot with upper case.

Also most if not all editors will highlight SQL keywords so it's probably not too hard to discern SQL commands and everything else in modern day.

load more comments (47 replies)