this post was submitted on 26 Jul 2023
42 points (97.7% liked)

Rust Programming

8197 readers
26 users here now

founded 5 years ago
MODERATORS
 

Whenever I encounter an interesting Rust programming technique, I add it to this blog post. I've amassed a bit of a collection. Hopefully someone finds it interesting and useful!

you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 2 points 1 year ago (3 children)

In tip #3 I don't see any benefit of doing impl AsRef<[T]> over &[T]

[–] [email protected] 1 points 1 year ago (2 children)

@calcopiritus @hatchet That way you can pass a reference or anything that can be turned into a reference as an argument. So the caller can supply a &T, Box, Rc, Arc, … (I dont’t know if there is a blanket impl so that even T itself will work.

[–] hatchet 1 points 1 year ago (1 children)

Well, actually I would tend to agree that &[T] is preferable to AsRef in most cases; all of the smart pointers you mentioned can also easily be turned into plain references. I probably could have chosen a better example.

[–] [email protected] 1 points 1 year ago

@hatchet That is true and I mostly agree with you. AsRef makes function signatures more complex and you effectively change a simple function into a generic function.

That said, when using some crates that make heavy use of this construction (especially when working with owned values in call chains) is sometimes significantly more ergonomic.

So AsRef definitely had it’s uses, but I agree that it probably shouldn’t be the recommended “best practice” for all crates.